Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755954Ab2FUPxd (ORCPT ); Thu, 21 Jun 2012 11:53:33 -0400 Received: from anubis.se.axis.com ([195.60.68.12]:55578 "EHLO anubis.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270Ab2FUPxc (ORCPT ); Thu, 21 Jun 2012 11:53:32 -0400 Date: Thu, 21 Jun 2012 17:53:27 +0200 From: Jesper Nilsson To: Bjorn Helgaas Cc: Jan Beulich , "linux-kernel@vger.kernel.org" , "mingo@elte.hu" , "tglx@linutronix.de" , linux-cris-kernel , "hpa@zytor.com" Subject: Re: [PATCH] x86/PCI: adjust section annotations Message-ID: <20120621155327.GZ25226@axis.com> References: <4FDF2044020000780008A66F@nat28.tlf.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1697 Lines: 39 On Thu, Jun 21, 2012 at 02:06:55AM +0200, Bjorn Helgaas wrote: > On Mon, Jun 18, 2012 at 4:34 AM, Jan Beulich wrote: > > DMI tables referenced from __init code only can be __initconst, and as > > a result the functions referenced from there can become __init. > > > > pcibios_setup() can be __init as being a command line parsing function > > only. > > > > A few other variables can then also have their attributes adjusted. > > This seems OK as far as it goes. > > However, if you're going to make pcibios_setup() __init for x86, I'd > really encourage you to make it consistent across all the other > architectures. And if you do *that*, I think it would be cool if you > supplied a generic do-nothing "weak" version in the PCI core. That > would allow you to remove it altogether from alpha, ia64, microblaze, > mips pmc-sierra, parisc, powerpc, sh, sparc, tile, and xtensa. > > CRIS-folk: It would also fix what looks like a bug in cris, which > implements pcibios_setup() such that pci_setup() doesn't even look for > all the supposedly generic options. Ok, thanks for the heads-up! I'm going to take a look at the PCI code in the CRIS-port. My current feeling is that the PCI support for CRIS probably should be dropped, both due to rotted code, but also that the hardware is hard to come by. I need to do some more digging around... /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/