Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759758Ab2FUQVi (ORCPT ); Thu, 21 Jun 2012 12:21:38 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34970 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759740Ab2FUQVh convert rfc822-to-8bit (ORCPT ); Thu, 21 Jun 2012 12:21:37 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 22 Jun 2012 00:21:34 +0800 Message-ID: Subject: Re: [PATCH] driver core: fix shutdown races with probe/remove(v2) From: Ming Lei To: Alan Stern Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 35 On Fri, Jun 22, 2012 at 12:12 AM, Alan Stern wrote: > On Fri, 22 Jun 2012, Ming Lei wrote: > >> On Thu, Jun 21, 2012 at 9:49 PM, Greg Kroah-Hartman >> wrote: >> >> > We also have not made the rule that a shutdown will complete in a >> > specific amount of time either, so there is no problem if that takes a >> > long time as well. >> >> OK, I will submit a new patch which just holds device lock. >> >> Alan, do you have objections on the new one? > > No objections. ?It should end up being pretty much like one of the > patches you posted earlier. Holding parent reference count is missed in earlier version. > > Should there be an option for a debug log of each device name just > before its shutdown routine is called? We have had the below before calling shutdown callback. dev_dbg(dev, "shutdown\n"); Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/