Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757619Ab2FVDLS (ORCPT ); Thu, 21 Jun 2012 23:11:18 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:64487 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757403Ab2FVDLQ convert rfc822-to-8bit (ORCPT ); Thu, 21 Jun 2012 23:11:16 -0400 MIME-Version: 1.0 In-Reply-To: References: <1340323926-6826-1-git-send-email-gshark.jeong@gmail.com> <1340323926-6826-2-git-send-email-gshark.jeong@gmail.com> From: Bryan Wu Date: Fri, 22 Jun 2012 11:10:55 +0800 X-Google-Sender-Auth: iEiZ3Bu8DbbUgqoYTM0rYsU069Y Message-ID: Subject: Re: [PATCH 1/1 v4] leds: Add LED driver for lm3556 chip To: "G.Shark Jeong" , "Kim, Milo" , Axel Lin Cc: "Jeong, Daniel" , Rob Landley , Richard Purdie , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 53 On Fri, Jun 22, 2012 at 9:05 AM, Kim, Milo wrote: >> LM3556 : >> The LM3556 is a 4 MHz fixed-frequency synchronous boost >> converter plus 1.5A constant current driver for a high-current white >> LED. > > Overall, it looks pretty good to me, especially core functionality of lm3556 is well supported and it's easy to use. > > Just one thing to be better, > I would suggest to use module_i2c_driver() rather than lm3556_init/lm3556_exit for code simplicity. > Hi G.Shark, I also think this patch is good enough for merging now after your fixed several issues pointed out by Axel Lin. I fixed this module_i2c_driver() issue mentioned by Milo here and push it to my -devel branch. If there is no problem, I will applied it to for-next branch. Thanks, -Bryan >> +static int __init lm3556_init(void) >> +{ >> + ? ? return i2c_add_driver(&lm3556_i2c_driver); >> +} >> + >> +static void __exit lm3556_exit(void) >> +{ >> + ? ? i2c_del_driver(&lm3556_i2c_driver); >> +} >> + >> +module_init(lm3556_init); >> +module_exit(lm3556_exit); > > module_i2c_driver(lm3556_i2c_driver); > > Thanks, > Milo - -- Bryan Wu Kernel Developer ? ?+86.186-168-78255 Mobile Canonical Ltd. ? ? ?www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/