Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932900Ab2FVMcu (ORCPT ); Fri, 22 Jun 2012 08:32:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55353 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932859Ab2FVMcr (ORCPT ); Fri, 22 Jun 2012 08:32:47 -0400 Date: Fri, 22 Jun 2012 14:32:44 +0200 From: Michal Hocko To: Wanpeng Li Cc: "linux-mm@kvack.org" , cgroups@vger.kernel.org, KAMEZAWA Hiroyuki , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel Subject: Re: [PATCH 2/2] memcg: cleanup typos in mem cgroup Message-ID: <20120622123244.GD4814@tiehlicka.suse.cz> References: <1340366474-28228-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340366474-28228-1-git-send-email-liwp.linux@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2259 Lines: 61 On Fri 22-06-12 20:01:14, Wanpeng Li wrote: > From: Wanpeng Li > > Signed-off-by: Wanpeng Li > > --- > mm/memcontrol.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 776fc57..9e3c74a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -115,8 +115,8 @@ static const char * const mem_cgroup_events_names[] = { > > /* > * Per memcg event counter is incremented at every pagein/pageout. With THP, > - * it will be incremated by the number of pages. This counter is used for > - * for trigger some periodic events. This is straightforward and better > + * it will be incremented by the number of pages. This counter is used for .... is used to trigger .... > + * trigger some periodic events. This is straightforward and better > * than using jiffies etc. to handle periodic memcg event. > */ > enum mem_cgroup_events_target { > @@ -678,7 +678,7 @@ mem_cgroup_largest_soft_limit_node(struct mem_cgroup_tree_per_zone *mctz) > * > * If there are kernel internal actions which can make use of some not-exact > * value, and reading all cpu value can be performance bottleneck in some > - * common workload, threashold and synchonization as vmstat[] should be > + * common workload, threshold and synchonization as vmstat[] should be > * implemented. > */ > static long mem_cgroup_read_stat(struct mem_cgroup *memcg, > @@ -2213,7 +2213,7 @@ static int mem_cgroup_do_charge(struct mem_cgroup *memcg, gfp_t gfp_mask, > if (mem_cgroup_wait_acct_move(mem_over_limit)) > return CHARGE_RETRY; > > - /* If we don't need to call oom-killer at el, return immediately */ > + /* If we don't need to call oom-killer at all, return immediately */ I think the whole comment should rather go away. > if (!oom_check) > return CHARGE_NOMEM; > /* check OOM */ -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/