Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932282Ab2FVTkV (ORCPT ); Fri, 22 Jun 2012 15:40:21 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:35448 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756469Ab2FVTkT (ORCPT ); Fri, 22 Jun 2012 15:40:19 -0400 Date: Fri, 22 Jun 2012 12:40:14 -0700 From: Greg KH To: richard -rw- weinberger Cc: Matthew Garrett , linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, Alex Lyashkov Subject: Re: [PATCH] Taint kernel when lve module is loaded Message-ID: <20120622194014.GA12874@kroah.com> References: <1340387371-32292-1-git-send-email-mjg59@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1669 Lines: 39 On Fri, Jun 22, 2012 at 09:09:22PM +0200, richard -rw- weinberger wrote: > On Fri, Jun 22, 2012 at 7:49 PM, Matthew Garrett wrote: > > Cloudlinux have a product called lve that includes a kernel module. This > > was previously GPLed but is now under a proprietary license, but the > > module continues to declare MODULE_LICENSE("GPL") and makes use of some > > EXPORT_SYMBOL_GPL symbols. Forcibly taint it in order to avoid this. > > > > Signed-off-by: Matthew Garrett > > Cc: Alex Lyashkov > > --- > > ?kernel/module.c | ? ?4 ++++ > > ?1 file changed, 4 insertions(+) > > > > diff --git a/kernel/module.c b/kernel/module.c > > index 4edbd9c..9ad9ee9 100644 > > --- a/kernel/module.c > > +++ b/kernel/module.c > > @@ -2730,6 +2730,10 @@ static int check_module_license_and_versions(struct module *mod) > > ? ? ? ?if (strcmp(mod->name, "driverloader") == 0) > > ? ? ? ? ? ? ? ?add_taint_module(mod, TAINT_PROPRIETARY_MODULE); > > > > + ? ? ? /* lve claims to be GPL but upstream won't provide source */ > > + ? ? ? if (strcmp(mod->name, "lve") == 0) > > + ? ? ? ? ? ? ? add_taint_module(mod, TAINT_PROPRIETARY_MODULE); > > + > > If this kernel module is really lying to us the kernel should simply > refuse to load it and > call a lawyer. The kernel can't call a lawyer, but other than that, this change does prevent the module from being loaded. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/