Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933190Ab2FVVLW (ORCPT ); Fri, 22 Jun 2012 17:11:22 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:52040 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932098Ab2FVVLU convert rfc822-to-8bit (ORCPT ); Fri, 22 Jun 2012 17:11:20 -0400 MIME-Version: 1.0 In-Reply-To: <20120622131901.28f273e3.akpm@linux-foundation.org> References: <1339690570-7471-1-git-send-email-kosaki.motohiro@gmail.com> <20120622131901.28f273e3.akpm@linux-foundation.org> From: KOSAKI Motohiro Date: Fri, 22 Jun 2012 17:10:59 -0400 Message-ID: Subject: Re: [PATCH] mm: clear pages_scanned only if draining a pcp adds pages to the buddy allocator again To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Rientjes , Mel Gorman , Johannes Weiner , Minchan Kim , Wu Fengguang , KAMEZAWA Hiroyuki , Rik van Riel Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 26 On Fri, Jun 22, 2012 at 4:19 PM, Andrew Morton wrote: > On Thu, 14 Jun 2012 12:16:10 -0400 > kosaki.motohiro@gmail.com wrote: > >> commit 2ff754fa8f (mm: clear pages_scanned only if draining a pcp adds pages >> to the buddy allocator again) fixed one free_pcppages_bulk() misuse. But two >> another miuse still exist. > > This changelog is irritating. ?One can understand it a bit if one > happens to have a git repo handy (and why do this to the reader?), but > the changelog for 2ff754fa8f indicates that the patch might fix a > livelock. ?Is that true of this patch? ?Who knows... The code in this simple patch speak the right usage, isn't it? And yes, this patch also fixes a possibility of live lock. (but i haven't seen actual live lock cause from this mistake) When anyone find a function misuse and fixes it, He/She should confirm other callsite and should all of mistake too. Otherwise we observe the same issue sooner of later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/