Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275Ab2FWKNq (ORCPT ); Sat, 23 Jun 2012 06:13:46 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56645 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394Ab2FWKNo (ORCPT ); Sat, 23 Jun 2012 06:13:44 -0400 Date: Sat, 23 Jun 2012 18:13:28 +0800 From: Wanpeng Li To: Johannes Weiner Cc: linux-mm@kvack.org, Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , Andrew Morton , Mel Gorman , Minchan Kim , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Gavin Shan , Wanpeng Li Subject: Re: [PATCH 4/6] memcg: move recent_rotated and recent_scanned informations Message-ID: <20120623101328.GA2153@kernel> Reply-To: Wanpeng Li References: <1340432259-5317-1-git-send-email-liwp.linux@gmail.com> <20120623095112.GO27816@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120623095112.GO27816@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 30 On Sat, Jun 23, 2012 at 11:51:13AM +0200, Johannes Weiner wrote: >On Sat, Jun 23, 2012 at 02:17:39PM +0800, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Move recent_rotated and recent_scanned prints next to inactive_anon, >> ative_anon, inactive_file, active_file, and unevictable prints to >> save developers' time. Since they have to go a long way(when cat memory.stat) >> to find recent_rotated and recent_scanned prints which has relationship >> with the memory cgroup we care. These prints are behind total_* which >> not just focus on the memory cgroup we care currently. > >The hierarchical stats are about that memcg, too. And I don't want to Move recent_rotated and recent_scanned prints next to file lru lists just because the pageout code in vmscan.c keeps track of how many of the mem/swap backed and file backed pages are referenced, and the higher the rotated/scanned ratio, the more valuable that cache is. Move five lru lists and associated debug informations together can make things convenience. :-) Regards, Wanpeng Li >turn on debugging and then look for the extra information hiding in >the middle of regular stats. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/