Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755771Ab2FWS36 (ORCPT ); Sat, 23 Jun 2012 14:29:58 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:61635 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518Ab2FWS35 convert rfc822-to-8bit (ORCPT ); Sat, 23 Jun 2012 14:29:57 -0400 MIME-Version: 1.0 In-Reply-To: <20120620230839.GA17883@kroah.com> References: <1340132742-18849-1-git-send-email-devendra.aaru@gmail.com> <20120620230839.GA17883@kroah.com> Date: Sat, 23 Jun 2012 23:59:57 +0530 Message-ID: Subject: Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems From: "devendra.aaru" To: Greg Kroah-Hartman Cc: "Justin P. Mattock" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 25 On Thu, Jun 21, 2012 at 4:38 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 20, 2012 at 12:35:42AM +0530, Devendra Naga wrote: >> - ? ? bit=(read_nic_byte_E(dev, EPROM_CMD) & (1<> + ? ? bit = (read_nic_byte_E(dev, EPROM_CMD) & (1<> ? ? ? udelay(EPROM_DELAY); >> >> - ? ? if(bit) return 1; >> - ? ? return 0; >> + ? ? return !!bit; > > Oh come on, really? ?!! is more "clear" here? > It looks ok to me, > No, please be painfully obvious, that's the only way to write kernel > code. ?Not like this. > Ok, so no !!'s ? and just that if (bit) thingy? > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/