Date: Sat, 23 Jun 2012 22:10:51 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "devendra.aaru" <devendra.aaru@gmail.com>
Cc: Joe Perches <joe@perches.com>, devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        "Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems
Message-ID: <20120623191051.GF5333@mwanda>
References: <1340132742-18849-1-git-send-email-devendra.aaru@gmail.com>
 <20120620230839.GA17883@kroah.com>
 <1340234315.29885.54.camel@joe2Laptop>
 <CAHdPZaMH1vJPsFmGFrrpWNtCxuY+S35-w2j+gbiiE=7jVKLtUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHdPZaMH1vJPsFmGFrrpWNtCxuY+S35-w2j+gbiiE=7jVKLtUQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1425
Lines: 47

On Sun, Jun 24, 2012 at 12:04:12AM +0530, devendra.aaru wrote:
> Hi Joe,
> 
> On Thu, Jun 21, 2012 at 4:48 AM, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2012-06-20 at 16:08 -0700, Greg Kroah-Hartman wrote:
> >> On Wed, Jun 20, 2012 at 12:35:42AM +0530, Devendra Naga wrote:
> >> > fixed some of the coding style problems reported by checkpatch
> > []
> >> > @@ -66,11 +69,10 @@ short eprom_r(struct net_device *dev)
> >> > ?{
> >> > ? ? short bit;
> >> >
> >> > - ? bit=(read_nic_byte_E(dev, EPROM_CMD) & (1<<EPROM_R_SHIFT) );
> >> > + ? bit = (read_nic_byte_E(dev, EPROM_CMD) & (1<<EPROM_R_SHIFT));
> >> > ? ? udelay(EPROM_DELAY);
> >> >
> >> > - ? if(bit) return 1;
> >> > - ? return 0;
> >> > + ? return !!bit;
> >>
> >> Oh come on, really? ?!! is more "clear" here?
> >
> > Depends on the reader. ?!! is pretty common.
> >
> >> No, please be painfully obvious, that's the only way to write kernel
> >> code. ?Not like this.
> >
> > I'd just make the return a bool instead.
> >
>  taking another variable and assign it like bool ret = !!bit, and
> returning ret?, i think this doesn't look better.

*eye roll*

	if (bit)
		return 1;
	return 0;

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/