Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756639Ab2FXAce (ORCPT ); Sat, 23 Jun 2012 20:32:34 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39029 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752717Ab2FXAcc (ORCPT ); Sat, 23 Jun 2012 20:32:32 -0400 X-Sasl-enc: 8t2uCfnQ9+CSmG7bXXgNdGm4j4jPoMTdrX6y35e4r01X 1340497951 Date: Sat, 23 Jun 2012 21:32:24 -0300 From: Henrique de Moraes Holschuh To: "Rafael J. Wysocki" Cc: platform-driver-x86@vger.kernel.org, Henrique de Moraes Holschuh , LKML , Linux PM list , Matthew Garrett , Joey Lee Subject: Re: [PATCH 1/5] thinkpad_acpi: Drop pm_message_t arguments from suspend routines Message-ID: <20120624003224.GA20885@khazad-dum.debian.net> References: <201206172226.42729.rjw@sisk.pl> <201206172227.23591.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201206172227.23591.rjw@sisk.pl> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 24 On Sun, 17 Jun 2012, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Multiple suspend routines in drivers/platform/x86/thinkpad_acpi.c > use take pm_message_t arguments that aren't used by any of them. > Make those routines take no arguments as that's what they should do. > > Signed-off-by: Rafael J. Wysocki Someday it might be necessary for some of these routines to differentiate S3 from suspend-to-disk, but I will introduce a parameter when that day comes. Acked-by: Henrique de Moraes Holschuh -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/