Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755973Ab2FXOme (ORCPT ); Sun, 24 Jun 2012 10:42:34 -0400 Received: from antcom.de ([188.40.178.216]:53006 "EHLO chuck.antcom.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210Ab2FXOmc (ORCPT ); Sun, 24 Jun 2012 10:42:32 -0400 Message-ID: <4FE72754.2000706@antcom.de> Date: Sun, 24 Jun 2012 16:42:28 +0200 From: Roland Stigge Organization: ANTCOM Open Source Research and Development User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: Dmitry Torokhov CC: axel.lin@gmail.com, riyer@nvidia.com, michael.hennerich@analog.com, grant.likely@secretlab.ca, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com, devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com Subject: Re: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx SoC References: <1339443891-15197-1-git-send-email-stigge@antcom.de> <20120621085623.GF2193@core.coreip.homeip.net> In-Reply-To: <20120621085623.GF2193@core.coreip.homeip.net> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 30 On 21/06/12 10:56, Dmitry Torokhov wrote: > On Mon, Jun 11, 2012 at 09:44:51PM +0200, Roland Stigge wrote: >> This patch adds a driver for the key scan interface of the LPC32xx SoC >> >> Signed-off-by: Roland Stigge >> For the DT binding: Acked-by: Rob Herring > > Not a real review, just a quick question - if th driver is DT-only now > do we need to have the platform data or it would make more sense to read > DT-bindings and fill the main device structure directly? And: >> + >> + matrix_keypad_build_keymap(NULL, NULL, kscandat->kscancfg->matrix_sz, >> + kscandat->kscancfg->matrix_sz, >> + kscandat->kscancfg->keymap, kscandat->input); > > This function may fail now. I'm addressing both issues in a updated patch. Thanks for the feedback, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/