Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756081Ab2FXOmi (ORCPT ); Sun, 24 Jun 2012 10:42:38 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59355 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210Ab2FXOme (ORCPT ); Sun, 24 Jun 2012 10:42:34 -0400 X-Sasl-enc: JJpsOB10cIQ5INLRMAyRqf8gNOqX/FFb729kDlhyIabm 1340548953 Date: Sun, 24 Jun 2012 11:42:30 -0300 From: Henrique de Moraes Holschuh To: Joe Perches Cc: Henrique de Moraes Holschuh , Matthew Garrett , Andrew Morton , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and tp_vdbg Message-ID: <20120624144230.GB24236@khazad-dum.debian.net> References: <20120624004051.GC20885@khazad-dum.debian.net> <1340507206.7758.30.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340507206.7758.30.camel@joe2Laptop> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 44 On Sat, 23 Jun 2012, Joe Perches wrote: > On Sat, 2012-06-23 at 21:40 -0300, Henrique de Moraes Holschuh wrote: > > On Sun, 17 Jun 2012, Joe Perches wrote: > > > Use a more current logging style. > > > > > > Add #define DEBUG and use pr_debug to enable dynamic debugging. > > > Coalesce formats and align arguments. > > > > > > Signed-off-by: Joe Perches > > > > Joe, are there any extra procedures required from the user to get the debug > > messages with this patch applied? > > No. > > The added #define DEBUG makes dynamic_debug emit those > messages automatically. Without the #define DEBUG, then I suspected as much, but I wanted direct confirmation. That #define DEBUG is a relatively recent enhancement to dynamic printk, isn't it? Something I will have to keep in mind if I resume doing backports of this driver for 2.6.32, 3.0 and 3.2 ? > these tp_[v]dbg calls might not be compiled in at all. > > These to_[v]dbg calls can be turned off via the normal > dyn_debug mechanisms. > > see: Documentation/dynamic-debug-howto.txt Ok. That's good enough for me. Acked-by: Henrique de Moraes Holschuh -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/