Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229Ab2FXUBB (ORCPT ); Sun, 24 Jun 2012 16:01:01 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:65457 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079Ab2FXUA7 (ORCPT ); Sun, 24 Jun 2012 16:00:59 -0400 Message-ID: <4FE771F6.7000206@tremplin-utc.net> Date: Sun, 24 Jun 2012 22:00:54 +0200 From: =?UTF-8?B?w4lyaWMgUGllbA==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Linux PM list , ACPI Devel Mailing List , LKML , Len Brown , Matthew Garrett , platform-driver-x86@vger.kernel.org, Mattia Dongili , Harald Welte Subject: Re: [PATCH 13/21] hp_accel: Use struct dev_pm_ops for power management References: <201206232306.06602.rjw@sisk.pl> <201206232316.20989.rjw@sisk.pl> In-Reply-To: <201206232316.20989.rjw@sisk.pl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2053 Lines: 70 On 23-06-12 23:16, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Make the hp_accel driver define its PM callbacks through > a struct dev_pm_ops object rather than by using legacy PM hooks > in struct acpi_device_ops. > > Signed-off-by: Rafael J. Wysocki Hello, Looks fine from my point of view. Reviewed-by: Éric Piel Éric > --- > drivers/platform/x86/hp_accel.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > Index: linux/drivers/platform/x86/hp_accel.c > =================================================================== > --- linux.orig/drivers/platform/x86/hp_accel.c > +++ linux/drivers/platform/x86/hp_accel.c > @@ -353,20 +353,22 @@ static int lis3lv02d_remove(struct acpi_ > > > #ifdef CONFIG_PM > -static int lis3lv02d_suspend(struct acpi_device *device) > +static int lis3lv02d_suspend(struct device *dev) > { > /* make sure the device is off when we suspend */ > lis3lv02d_poweroff(&lis3_dev); > return 0; > } > > -static int lis3lv02d_resume(struct acpi_device *device) > +static int lis3lv02d_resume(struct device *dev) > { > return lis3lv02d_poweron(&lis3_dev); > } > + > +static SIMPLE_DEV_PM_OPS(hp_accel_pm, lis3lv02d_suspend, lis3lv02d_resume); > +#define HP_ACCEL_PM (&hp_accel_pm) > #else > -#define lis3lv02d_suspend NULL > -#define lis3lv02d_resume NULL > +#define HP_ACCEL_PM NULL > #endif > > /* For the HP MDPS aka 3D Driveguard */ > @@ -377,9 +379,8 @@ static struct acpi_driver lis3lv02d_driv > .ops = { > .add = lis3lv02d_add, > .remove = lis3lv02d_remove, > - .suspend = lis3lv02d_suspend, > - .resume = lis3lv02d_resume, > - } > + }, > + .drv.pm = HP_ACCEL_PM, > }; > > static int __init lis3lv02d_init_module(void) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/