Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832Ab2FXUhY (ORCPT ); Sun, 24 Jun 2012 16:37:24 -0400 Received: from terminus.zytor.com ([198.137.202.10]:45882 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036Ab2FXUhW (ORCPT ); Sun, 24 Jun 2012 16:37:22 -0400 Message-ID: <4FE77A6C.3050908@zytor.com> Date: Sun, 24 Jun 2012 13:37:00 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Jean Delvare CC: mingo@kernel.org, linux-kernel@vger.kernel.org, JBeulich@suse.com, tglx@linutronix.de, hpa@linux.intel.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM References: <4FE34BCB.5050305@linux.intel.com> <20120624214908.4177fc4a@endymion.delvare> In-Reply-To: <20120624214908.4177fc4a@endymion.delvare> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 50 On 06/24/2012 12:49 PM, Jean Delvare wrote: >> >> Therefore, rename this to "dtherm". > > I see the rationale for changing the string in /proc/cpuinfo, and > "dtherm" is reasonably good. I fail to see the rationale for changing > the X86_FEATURE_ name though, this is an API change we don't need. Plus > X86_FEATURE_DTS has the merit of naming the feature the way it is > commonly done in technical documentation, so readers know exactly what > it refers too, which isn't the case of DTHERM. So can we please stick > to X86_FEATURE_DTS? > Except that *really* seems like begging for similar problems in the future. >> This conflict went into mainline via the hwmon tree without any x86 >> maintainer ack, and without any kind of hint in the subject. >> >> a4659053 x86/hwmon: fix initialization of coretemp > > All 3 x86 maintainers were Cc'd, none commented. And you know fairly > well why the patch went through the hwmon tree. So please stop the > finger-pointing. It's unfortunate that it happened, but it did, and we > try to fix it now, period. > >> Reported-by: Jean Delvare >> Link: http://lkml.kernel.org/r/4FE34BCB.5050305@linux.intel.com >> Cc: Jan Beulich >> Cc: v2.6.36..v3.4 > > No Signed-off-by? > > Not sure why you want this to go to stable trees? > I think we want to minimize the ABI divergence here. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/