Message-ID: <1340645735.18025.88.camel@twins>
Subject: Re: [PATCH 00/12] kmap_atomic cleanup for 3.6
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Cong Wang <amwang@redhat.com>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        dhowells <dhowells@redhat.com>
Date: Mon, 25 Jun 2012 19:35:35 +0200
In-Reply-To: <201206251518.08791.arnd@arndb.de>
References: <1340445863-16111-1-git-send-email-amwang@redhat.com>
	 <201206232111.25411.arnd@arndb.de> <1340598382.19173.3.camel@cr0>
	 <201206251518.08791.arnd@arndb.de>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 907
Lines: 22

On Mon, 2012-06-25 at 15:18 +0000, Arnd Bergmann wrote:
> > Different arch has different values for KM_TYPE_NR, I am not sure if
> > unifying them to a fixed value could fit all? 

No you can't. Some arch's have arch specific KM_TYPE thingies, like FRV.

> > For safety, I kept their original values.
> 
> My fear is that it will make it harder to clean that code up for
> real, when there is no longer an indication about where the number
> comes from.

Agreed, I'd much prefer it if we'd come up with a sane way to compute
the max value before doing away with these enums.

Sadly I haven't been able to come up with a sane way short of whole
program analysis.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/