Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757747Ab2FYWap (ORCPT ); Mon, 25 Jun 2012 18:30:45 -0400 Received: from mx2.parallels.com ([64.131.90.16]:53474 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757430Ab2FYWan (ORCPT ); Mon, 25 Jun 2012 18:30:43 -0400 Message-ID: <4FE8E5F0.9080406@parallels.com> Date: Tue, 26 Jun 2012 02:28:00 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Tejun Heo CC: , , Andrew Morton , , Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , , , Pekka Enberg Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625180619.GD3869@google.com> In-Reply-To: <20120625180619.GD3869@google.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [109.173.9.3] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 46 On 06/25/2012 10:06 PM, Tejun Heo wrote: > Again, nits. > > On Mon, Jun 25, 2012 at 06:15:23PM +0400, Glauber Costa wrote: >> +#define mem_cgroup_kmem_on 1 >> +bool __mem_cgroup_new_kmem_page(gfp_t gfp, void *handle, int order); >> +void __mem_cgroup_commit_kmem_page(struct page *page, void *handle, int order); >> +void __mem_cgroup_free_kmem_page(struct page *page, int order); >> +#define is_kmem_tracked_alloc (gfp & __GFP_KMEMCG) > > Ugh... please do the following instead. > > static inline bool is_kmem_tracked_alloc(gfp_t gfp) > { > return gfp & __GFP_KMEMCG; > } > >> #else >> static inline void sock_update_memcg(struct sock *sk) >> { >> @@ -416,6 +423,43 @@ static inline void sock_update_memcg(struct sock *sk) >> static inline void sock_release_memcg(struct sock *sk) >> { >> } >> + >> +#define mem_cgroup_kmem_on 0 >> +#define __mem_cgroup_new_kmem_page(a, b, c) false >> +#define __mem_cgroup_free_kmem_page(a,b ) >> +#define __mem_cgroup_commit_kmem_page(a, b, c) >> +#define is_kmem_tracked_alloc (false) > > I would prefer static inlines here too. It's a bit more code in the > header but leads to less surprises (e.g. arg evals w/ side effects or > compiler warning about unused vars) and makes it easier to avoid > cosmetic errors. > > Thanks. > Sure thing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/