Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757917Ab2FYXho (ORCPT ); Mon, 25 Jun 2012 19:37:44 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:52956 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757795Ab2FYXhm (ORCPT ); Mon, 25 Jun 2012 19:37:42 -0400 Date: Mon, 25 Jun 2012 16:37:37 -0700 From: Greg Kroah-Hartman To: Seth Jennings Cc: devel@driverdev.osuosl.org, Dan Magenheimer , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Minchan Kim , Andrew Morton , Robert Jennings , Nitin Gupta Subject: Re: [PATCH 2/3] zsmalloc: add generic path and remove x86 dependency Message-ID: <20120625233737.GA3493@kroah.com> References: <1340640878-27536-1-git-send-email-sjenning@linux.vnet.ibm.com> <1340640878-27536-3-git-send-email-sjenning@linux.vnet.ibm.com> <20120625165915.GA20464@kroah.com> <4FE89BA1.3030709@linux.vnet.ibm.com> <20120625171939.GA29371@kroah.com> <4FE8ACDD.3070007@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FE8ACDD.3070007@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2011 Lines: 50 On Mon, Jun 25, 2012 at 01:24:29PM -0500, Seth Jennings wrote: > On 06/25/2012 12:19 PM, Greg Kroah-Hartman wrote: > > On Mon, Jun 25, 2012 at 12:10:57PM -0500, Seth Jennings wrote: > >> On 06/25/2012 11:59 AM, Greg Kroah-Hartman wrote: > >>> On Mon, Jun 25, 2012 at 11:14:37AM -0500, Seth Jennings wrote: > >>>> This patch adds generic pages mapping methods that > >>>> work on all archs in the absence of support for > >>>> local_tlb_flush_kernel_range() advertised by the > >>>> arch through __HAVE_LOCAL_TLB_FLUSH_KERNEL_RANGE > >>> > >>> Is this #define something that other arches define now? Or is this > >>> something new that you are adding here? > >> > >> Something new I'm adding. > > > > Ah, ok. > > > >> The precedent for this approach is the __HAVE_ARCH_* defines > >> that let the arch independent stuff know if a generic > >> function needs to be defined or if there is an arch specific > >> function. > >> > >> You can "grep -R __HAVE_ARCH_* arch/x86/" to see the ones > >> that already exist. > >> > >> I guess I should have called it > >> __HAVE_ARCH_LOCAL_TLB_FLUSH_KERNEL_RANGE though, not > >> __HAVE_LOCAL_TLB_FLUSH_KERNEL_RANGE. > > > > You need to get the mm developers to agree with this before I can take > > it. > > > > But, why even depend on this? Can't you either live without it > > The whole point of the patch is _not_ to depend on it. It > just performs worse without it. We could just rip out all > the the page table assisted page mapping, but, for the > arches that have support for it, we'd be degrading > performance in exchange for portability. Why choose when we > can have both? Ok, I'll let you fight it out with the mm people before applying these 2 patches, I've applied the first one only for now. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/