Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756120Ab2FZJSo (ORCPT ); Tue, 26 Jun 2012 05:18:44 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:40793 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755305Ab2FZJSm (ORCPT ); Tue, 26 Jun 2012 05:18:42 -0400 X-IronPort-AV: E=Sophos;i="4.77,476,1336320000"; d="scan'208";a="5266100" Message-ID: <4FE97F7B.2030808@cn.fujitsu.com> Date: Tue, 26 Jun 2012 17:23:07 +0800 From: Wen Congyang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: lenb@kernel.org, linux-acpi@vger.kernel.org, "linux-kernel@vger.kernel.org" CC: Yasuaki ISIMATU Subject: [PATCH 8/8] release memory resources if hotadd_new_pgdat() failed References: <4FE97DD5.6030205@cn.fujitsu.com> In-Reply-To: <4FE97DD5.6030205@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/06/26 17:18:54, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/06/26 17:18:54, Serialize complete at 2012/06/26 17:18:54 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 28 We should goto error to release memory resource if hotadd_new_pgdat() failed. Signed-off-by: Wen Congyang --- mm/memory_hotplug.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 2a14d35..3796690 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -617,7 +617,7 @@ int __ref add_memory(int nid, u64 start, u64 size) pgdat = hotadd_new_pgdat(nid, start); ret = -ENOMEM; if (!pgdat) - goto out; + goto error; new_pgdat = 1; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/