Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758632Ab2FZPt6 (ORCPT ); Tue, 26 Jun 2012 11:49:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19406 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758515Ab2FZPt5 (ORCPT ); Tue, 26 Jun 2012 11:49:57 -0400 Date: Tue, 26 Jun 2012 17:47:36 +0200 From: Oleg Nesterov To: Anton Arapov Cc: Ingo Molnar , Peter Zijlstra , Srikar Dronamraju , Ananth N Mavinakayanahalli , Hugh Dickins , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] uprobes: __replace_page() needs munlock_vma_page() Message-ID: <20120626154736.GA16141@redhat.com> References: <20120624145936.GA23269@redhat.com> <20120624150111.GE23277@redhat.com> <20120626115514.GA16794@bandura.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120626115514.GA16794@bandura.brq.redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 35 On 06/26, Anton Arapov wrote: > > On Sun, Jun 24, 2012 at 05:01:11PM +0200, Oleg Nesterov wrote: > > Like do_wp_page(), __replace_page() should do munlock_vma_page() > > for the case when the old page still has other !VM_LOCKED mappings. > > Unfortunately this needs mm/internal.h. > > > > --- a/kernel/events/uprobes.c > > +++ b/kernel/events/uprobes.c > > @@ -32,6 +32,7 @@ > > #include /* try_to_free_swap */ > > #include /* user_enable_single_step */ > > #include /* notifier mechanism */ > > +#include "../../mm/internal.h" /* munlock_vma_page */ > > We have vma_adress() defined in internal.h, under #ifdef CONFIG_TRANSPARENT_HUGEPAGE . > > NAK. :-) Damn you Anton ;) You seem to dislike number 5... OK, please ignore this patch. Can't resist. I swear, I specially checked mm/internal.h to ensure it doesn't export mm/rmap.c:vma_address(), can't understand how I didn't notice this declaration. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/