Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758638Ab2FZPvV (ORCPT ); Tue, 26 Jun 2012 11:51:21 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:42964 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756880Ab2FZPvU (ORCPT ); Tue, 26 Jun 2012 11:51:20 -0400 Date: Tue, 26 Jun 2012 11:51:15 -0400 From: Christoph Hellwig To: Mike Snitzer Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, tj@kernel.org, hch@infradead.org, jmoyer@redhat.com, vgoyal@redhat.com, dm-devel@redhat.com Subject: Re: [RFC PATCH] block: all callers should check blkdev_issue_flush's return Message-ID: <20120626155115.GA17242@infradead.org> References: <1340724445-3314-1-git-send-email-snitzer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340724445-3314-1-git-send-email-snitzer@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 17 On Tue, Jun 26, 2012 at 11:27:25AM -0400, Mike Snitzer wrote: > It is concerning that a FLUSH may fail but the blkdev_issue_flush > callers assume it will always succeed. > > Each blkdev_issue_flush caller should come to terms with the reality > that a FLUSH may fail -- the file_operations' .fsync methods in > particular. nilfs2 is the only filesystem that checks > blkdev_issue_flush's return. Good spot, but it would be way better if you actually provided patches to fix this instead of just adding more compiler warnings. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/