Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758737Ab2FZRCi (ORCPT ); Tue, 26 Jun 2012 13:02:38 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:44303 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757916Ab2FZRCg (ORCPT ); Tue, 26 Jun 2012 13:02:36 -0400 Date: Tue, 26 Jun 2012 10:02:32 -0700 From: Greg Kroah-Hartman To: Kay Sievers Cc: Linus Torvalds , Andrew Morton , Steven Rostedt , LKML , Ingo Molnar , Wu Fengguang , Joe Perches , "Paul E. McKenney" Subject: Re: [PATCH v3] printk: Have printk() never buffer its data Message-ID: <20120626170232.GA2041@kroah.com> References: <20120625150722.8cd4f45d.akpm@linux-foundation.org> <20120625235531.GB3652@kroah.com> <20120626002307.GA4389@kroah.com> <1340726856.977.6.camel@mop> <20120626165855.GA1851@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 36 On Tue, Jun 26, 2012 at 07:00:38PM +0200, Kay Sievers wrote: > On Tue, Jun 26, 2012 at 6:58 PM, Greg Kroah-Hartman > wrote: > > On Tue, Jun 26, 2012 at 06:07:36PM +0200, Kay Sievers wrote: > >> On Mon, 2012-06-25 at 18:40 -0700, Linus Torvalds wrote: > >> > On Mon, Jun 25, 2012 at 5:56 PM, Kay Sievers wrote: > >> > > > >> > > Buffering has nice effects though: > >> > > It makes continuation lines appear as one record in the buffer, not as > >> > > n individual prints with n headers. > >> > > >> > As I already mentioned, buffering for *logging* is different from > >> > buffering for *printing*. > >> > > >> > I think it might be a great idea to buffer for logging in order to > >> > generate one individual buffer record there. > >> > > >> > But it needs to be printed as it is generated. > >> > >> That's a good idea. > >> > >> Something like this could work - only minimally tested at this moment. > > > > Hm, this doesn't boot for me, just hangs at startup :( > > You have that patch against your tree? Let me try that, maybe it > conflicts with one of the patches there ... No, I applied to to a clean 3.5-rc4 (which boots fine on my laptop). greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/