Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755751Ab2F0BFR (ORCPT ); Tue, 26 Jun 2012 21:05:17 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:59384 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755427Ab2F0BFP (ORCPT ); Tue, 26 Jun 2012 21:05:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <1339479468-3815-1-git-send-email-zheng.z.yan@intel.com> <4FD7EFCB.6060005@intel.com> <1339578142.31548.128.camel@twins> <4FD949FF.7060207@intel.com> Date: Wed, 27 Jun 2012 03:05:13 +0200 Message-ID: Subject: Re: [PATCH V5 0/13] perf: Intel uncore pmu counting support From: Stephane Eranian To: "Yan, Zheng" Cc: Peter Zijlstra , mingo@elte.hu, jolsa@redhat.com, andi@firstfloor.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 33 Hi, If you compile the uncore support in 32-bit mode, you will get a warning on the hrtimer_start_range_ns() functions because the interval is passed as ktime_t whereas the function expects unsigned long. With 64-bit, no problem ktime_t is a union with s64. But in 32-bit mode, there is a possible truncation of the delta. This needs to be fixed. On Thu, Jun 14, 2012 at 7:41 AM, Stephane Eranian wrote: > On Thu, Jun 14, 2012 at 4:18 AM, Yan, Zheng wrote: >> On 06/13/2012 05:02 PM, Peter Zijlstra wrote: >>> On Wed, 2012-06-13 at 09:41 +0800, Yan, Zheng wrote: >>>> Peter suggests keeping the uncore names as they're listed in the intel >>>> doc. For Sandybirdge-EP, uncore names are something like: Cbo, iMC, >>>> QPI. >>> >>> No they're not, they're C-Box etc.. but I'm fine with doing a tolower on >>> all of it. >>> >> >> The reason I choose CBox instead of C-Box is that '-' is a separate symbol >> in the flex rules. '-' is used for matching events such as LLC-load-misses. >> I don't know how to allow letter '-' in the pmu name, but without leading >> to ambiguity. >> > I would drop the -, just call it cbox. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/