Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754782Ab2F0I7W (ORCPT ); Wed, 27 Jun 2012 04:59:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524Ab2F0I7U (ORCPT ); Wed, 27 Jun 2012 04:59:20 -0400 Date: Wed, 27 Jun 2012 10:59:18 +0200 From: Michal Hocko To: Glauber Costa Cc: Wanpeng Li , Andrew Morton , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx Message-ID: <20120627085917.GA5683@tiehlicka.suse.cz> References: <1340756175-3420-1-git-send-email-liwp.linux@gmail.com> <4FEAC7C6.7030601@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FEAC7C6.7030601@parallels.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 35 On Wed 27-06-12 12:43:50, Glauber Costa wrote: > On 06/27/2012 04:16 AM, Wanpeng Li wrote: > >From: Wanpeng Li > > > >Changelog: > > > >V2 -> V1: > > > >* replace memory_cgroup_xxx by memcg_xxx > > > >Unify memcg functions to memcg_xxx. > > > This patch achieves nothing. > You're changing a couple of function names. Andrew stated goal was > to change *all* function names from mem_cgroup_xxx to memcg_xxx, not > just one or two. No mass things now, please. git grep mem_cgroup_ mm/ include/ | wc -l 863 This will be real pain for merging. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/