Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755774Ab2F0JDB (ORCPT ); Wed, 27 Jun 2012 05:03:01 -0400 Received: from mx2.parallels.com ([64.131.90.16]:38761 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab2F0JC7 (ORCPT ); Wed, 27 Jun 2012 05:02:59 -0400 Message-ID: <4FEACBA4.10202@parallels.com> Date: Wed, 27 Jun 2012 13:00:20 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Michal Hocko CC: Wanpeng Li , Andrew Morton , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh , , Subject: Re: [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx References: <1340756175-3420-1-git-send-email-liwp.linux@gmail.com> <4FEAC7C6.7030601@parallels.com> <20120627085917.GA5683@tiehlicka.suse.cz> In-Reply-To: <20120627085917.GA5683@tiehlicka.suse.cz> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 36 On 06/27/2012 12:59 PM, Michal Hocko wrote: > On Wed 27-06-12 12:43:50, Glauber Costa wrote: >> On 06/27/2012 04:16 AM, Wanpeng Li wrote: >>> From: Wanpeng Li >>> >>> Changelog: >>> >>> V2 -> V1: >>> >>> * replace memory_cgroup_xxx by memcg_xxx >>> >>> Unify memcg functions to memcg_xxx. >> >> >> This patch achieves nothing. >> You're changing a couple of function names. Andrew stated goal was >> to change *all* function names from mem_cgroup_xxx to memcg_xxx, not >> just one or two. > > No mass things now, please. > git grep mem_cgroup_ mm/ include/ | wc -l > 863 > > This will be real pain for merging. > It's either that, or I have my new functions named memcg_ and we live with the inconsistency. Point is, changing one function name as he did, achieves nothing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/