Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756483Ab2F0JQA (ORCPT ); Wed, 27 Jun 2012 05:16:00 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:57110 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754383Ab2F0JP7 (ORCPT ); Wed, 27 Jun 2012 05:15:59 -0400 Message-ID: <4FEACFD9.7020503@linaro.org> Date: Wed, 27 Jun 2012 13:18:17 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Namhyung Kim , Ingo Molnar , Paul Mackerras , Peter Zijlstra , linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, Amit Kucheria Subject: Re: [PATCH] perf sched replay: fix event lookup References: <1339232758-920-1-git-send-email-dmitry.antipov@linaro.org> <87pq96pfj9.fsf@sejong.aot.lge.com> <20120611140852.GB2202@infradead.org> <8739616pc9.fsf@sejong.aot.lge.com> <20120625232016.GA28525@infradead.org> In-Reply-To: <20120625232016.GA28525@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 29 On 06/26/2012 03:20 AM, Arnaldo Carvalho de Melo wrote: > >> Fair enough. The method should be a simple wrapper to libtraceevent APIs >> like this patch. > > The pevent thing is per perf.data file, so I made it stop being static > and become a perf_session member, so tools processing perf.data files > use perf_session and _there_ we read the event into session->pevent and > then have to change everywhere to stop using that single global pevent > variable and use the per session one. > > Dmitry, can you test the attached patch to check if it solves the > problems you reported? This looks good and works for my x86 <-> ARM tests. > Note that it _doesn't_ fall backs to trace__event_id, as we're not > interested at all in what is present in the > /sys/kernel/debug/tracing/events in the workstation doing the analysis, > just in what is in the perf.data file. Agree. Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/