Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754873Ab2F0JUt (ORCPT ); Wed, 27 Jun 2012 05:20:49 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:34140 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884Ab2F0JUr (ORCPT ); Wed, 27 Jun 2012 05:20:47 -0400 Message-ID: <4FEAD06A.2030302@mev.co.uk> Date: Wed, 27 Jun 2012 10:20:42 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120616 Thunderbird/13.0 MIME-Version: 1.0 To: H Hartley Sweeten CC: Linux Kernel , "devel@driverdev.osuosl.org" , Ian Abbott , "fmhess@users.sourceforge.net" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH 16/36] staging: comedi: cb_pcidas: simplify the boardinfo References: <201206261756.44046.hartleys@visionengravers.com> In-Reply-To: <201206261756.44046.hartleys@visionengravers.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 23 On 2012-06-27 01:56, H Hartley Sweeten wrote: > The boardinfo values 'has_ai_trig_gated' and 'has_ai_trig_invert' > are both only set for the "1602" versions of the boards supported > by this driver. > > Simplify the boardinfo, and the code, by replacing these two > variables with one "is_1602" variable. This doesn't save any code and would make it harder to add a board that would need 'has_ai_trig_gated' and 'has_ai_trig_invert' set to different values (although it's pretty unlikely that new such boards would be added to this driver). -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/