Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756518Ab2F0M0v (ORCPT ); Wed, 27 Jun 2012 08:26:51 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:64443 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754312Ab2F0M0t convert rfc822-to-8bit (ORCPT ); Wed, 27 Jun 2012 08:26:49 -0400 MIME-Version: 1.0 In-Reply-To: <4FEAF90B.5030809@antcom.de> References: <1339064536-20553-1-git-send-email-stigge@antcom.de> <1340794007.29342.50.camel@sauron.fi.intel.com> <4FEAF90B.5030809@antcom.de> Date: Wed, 27 Jun 2012 09:26:48 -0300 Message-ID: Subject: Re: [PATCH v7] MTD: LPC32xx SLC NAND driver From: Alexandre Pereira da Silva To: Roland Stigge Cc: dedekind1@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com, linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com, lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com, linux@arm.linux.org.uk Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1347 Lines: 31 On Wed, Jun 27, 2012 at 9:14 AM, Roland Stigge wrote: > On 06/27/2012 12:46 PM, Artem Bityutskiy wrote: >> On Thu, 2012-06-07 at 12:22 +0200, Roland Stigge wrote: >>> This patch adds support for the SLC NAND controller inside the >>> LPC32xx SoC. >>> >>> Signed-off-by: Roland Stigge >> >> Now the write_page and write_page_raw functions return an error >> code, see this commit in the l2 tree: >> >> http://git.infradead.org/users/dedekind/l2-mtd.git/commit/49c8d9ab3b70732665249f2d993f734378ebbba9 >> >> ?I've amended your SLC driver, see below the diff. But I think it >> could return the real return code becuse it can fail - could you >> please take a look and send an incremental patch? >> >> Please, base your work on top of the l2-mtd tree: >> git://git.infradead.org/users/dedekind/l2-mtd.git > > Thanks for the note! I'm sending an incremental patch. There was > actually only one place in the two functions that could fail (return > code of lpc32xx_xfer()). I think it's best in case of *_raw to use nand base default functions, like in the MLC patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/