Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757185Ab2F0MhJ (ORCPT ); Wed, 27 Jun 2012 08:37:09 -0400 Received: from casper.infradead.org ([85.118.1.10]:52252 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753616Ab2F0MhH convert rfc822-to-8bit (ORCPT ); Wed, 27 Jun 2012 08:37:07 -0400 Message-ID: <1340800594.10063.53.camel@twins> Subject: Re: [PATCH v4 12/13] fair.c: Use generic rbtree impl in fair scheduler From: Peter Zijlstra To: Daniel Santos Cc: Andrew Morton , Christopher Li , David Daney , David Howells , David Rientjes , Hidetoshi Seto , "H. Peter Anvin" , Ingo Molnar , Ingo Molnar , Joe Perches , Konstantin Khlebnikov , linux-doc@vger.kernel.org, linux-sparse@vger.kernel.org, LKML , Paul Gortmaker , Paul Turner , Pavel Pisa , Richard Weinberger , Rob Landley , Steven Rostedt , Suresh Siddha Date: Wed, 27 Jun 2012 14:36:34 +0200 In-Reply-To: <4FEA30B2.9010902@att.net> References: <1340424048-7759-1-git-send-email-daniel.santos@pobox.com> <1340424048-7759-13-git-send-email-daniel.santos@pobox.com> <1340712949.21991.57.camel@twins> <4FEA30B2.9010902@att.net> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 24 On Tue, 2012-06-26 at 16:59 -0500, Daniel Santos wrote: > Also, to address why we're not using entity_before (or a less() > function) directly, there's two main reasons (one that doesn't even > affect CFS). The first reason is that an "is equal" evaluation would > also be required for insertions in trees with unique keys, Right, I saw that feature in your code, are there any such trees in the kernel? It would be good to have a kernel code conversion for each variant your code supports. > as well as > all lookups. This doesn't doesn't affect CFS because it isn't doing > lookups (it only cares about leftmost) and duplicate keys are allowed. > Right.. there's that. Too bad, partial order is slightly cheaper at times. A well, nothing for it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/