MIME-Version: 1.0
Importance: Normal
In-Reply-To: <20120627133332.GA21572@pengutronix.de>
References: <20120627133332.GA21572@pengutronix.de>,
	<1340749442.3241.4046.camel@pc786-ubu.gnet.global.vpn>
Subject: Re: [PATCH] rtc: ds1307: Register offset moved to chip description
From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
        Austin Boyle <Austin.Boyle@aviatnet.com>, linux-kernel@vger.kernel.org,
        rtc-linux@googlegroups.com
Message-ID: <OFD3CD15E9.315EBD6D-ONC1257A2A.004B4768-C1257A2A.004B476C@transmode.se>
Date: Wed, 27 Jun 2012 15:42:14 +0200
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 32

> 
> On Wed, Jun 27, 2012 at 10:24:02AM +1200, Austin Boyle wrote:
> > rtc: ds1307: Register offset moved to chip description
> > 
> > From: Austin Boyle <Austin.Boyle@aviatnet.com>
> > 
> > Register offset is added to chip description instead of being hard-coded
> > into probe function.
> > 
> > Based on v3.5-rc4
> > 
> > Cc: Wolfram Sang <w.sang@pengutronix.de>
> > Cc: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > Cc: Alessandro Zummo <a.zummo@towertech.it>
> > Signed-off-by: Austin Boyle <Austin.Boyle@aviatnet.com>
> 
> I would ack this patch immediately if it added another type using this
> feature. But only changing already working code doesn't seem necessary
> to me.
> 
> Regards,
> 
>     Wolfram
> 

That was my gut feeling too.

  Jocke--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/