Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757081Ab2F0OVq (ORCPT ); Wed, 27 Jun 2012 10:21:46 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:63450 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753546Ab2F0OVp (ORCPT ); Wed, 27 Jun 2012 10:21:45 -0400 Date: Wed, 27 Jun 2012 11:21:39 -0300 From: Arnaldo Carvalho de Melo To: Dmitry Antipov Cc: Namhyung Kim , Ingo Molnar , Paul Mackerras , Peter Zijlstra , linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, Amit Kucheria Subject: Re: [PATCH] perf sched replay: fix event lookup Message-ID: <20120627142139.GA2693@infradead.org> References: <1339232758-920-1-git-send-email-dmitry.antipov@linaro.org> <87pq96pfj9.fsf@sejong.aot.lge.com> <20120611140852.GB2202@infradead.org> <8739616pc9.fsf@sejong.aot.lge.com> <20120625232016.GA28525@infradead.org> <4FEACFD9.7020503@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FEACFD9.7020503@linaro.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 32 Em Wed, Jun 27, 2012 at 01:18:17PM +0400, Dmitry Antipov escreveu: > On 06/26/2012 03:20 AM, Arnaldo Carvalho de Melo wrote: > > > >>Fair enough. The method should be a simple wrapper to libtraceevent APIs > >>like this patch. > > > >The pevent thing is per perf.data file, so I made it stop being static > >and become a perf_session member, so tools processing perf.data files > >use perf_session and _there_ we read the event into session->pevent and > >then have to change everywhere to stop using that single global pevent > >variable and use the per session one. > > > >Dmitry, can you test the attached patch to check if it solves the > >problems you reported? > > This looks good and works for my x86 <-> ARM tests. Thanks, adding your Tested-by: Dmitry, ok? > >Note that it _doesn't_ fall backs to trace__event_id, as we're not > >interested at all in what is present in the > >/sys/kernel/debug/tracing/events in the workstation doing the analysis, > >just in what is in the perf.data file. > > Agree. > > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/