Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755976Ab2F0THh (ORCPT ); Wed, 27 Jun 2012 15:07:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46086 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755583Ab2F0THe (ORCPT ); Wed, 27 Jun 2012 15:07:34 -0400 Date: Wed, 27 Jun 2012 21:07:25 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Namhyung Kim , Jovi Zhang , mingo@redhat.com, Peter Zijlstra , LKML Subject: Re: [PATCH] perf: fix wrong hw_breakpoint documentation Message-ID: <20120627190725.GA1380@krava.redhat.com> References: <87fw9hyvt5.fsf@sejong.aot.lge.com> <20120627161557.GA3878@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120627161557.GA3878@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 51 On Wed, Jun 27, 2012 at 01:15:57PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 27, 2012 at 05:59:34PM +0900, Namhyung Kim escreveu: > > Hi, Jovi > > > > On Wed, 27 Jun 2012 16:39:19 +0800, Jovi Zhang wrote: > > > From f5f9c3a064482cf3d0fb7ed788c66630bddbfc79 Mon Sep 17 00:00:00 2001 > > > From: Jovi Zhang > > > Date: Wed, 27 Jun 2012 16:09:21 +0800 > > > Subject: [PATCH] perf: fix wrong hw_breakpoint documentation > > > > > > read-write access hw_breakpoint event is passed as 'mem:addr', > > > 'mem:0x1000:rw' is parsed as invalid argument currently. > > > > > > > It should be a bug in event parser. I guess the patch below will fix it: > > Jiri, > > Ack? If so, Namhyung, can you send a patch with his Ack? > > - Arnaldo > > > > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > > index 488362e14133..aafca33a8a09 100644 > > --- a/tools/perf/util/parse-events.l > > +++ b/tools/perf/util/parse-events.l > > @@ -76,7 +76,7 @@ num_hex 0x[a-fA-F0-9]+ > > num_raw_hex [a-fA-F0-9]+ > > name [a-zA-Z_*?][a-zA-Z0-9_*?]* > > modifier_event [ukhpGH]{1,8} > > -modifier_bp [rwx] > > +modifier_bp [rwx]+ > > > > %% > > we could have it more precise with -modifier_bp [rwx] +modifier_bp [rwx]{1,3} and fail parse_breakpoint_type function for nonsense types aaand automated tests updated ;) jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/