Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757111Ab2F0T0W (ORCPT ); Wed, 27 Jun 2012 15:26:22 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:62560 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756758Ab2F0T0T convert rfc822-to-8bit (ORCPT ); Wed, 27 Jun 2012 15:26:19 -0400 MIME-Version: 1.0 In-Reply-To: <20120627191542.GC25319@n2100.arm.linux.org.uk> References: <1340812275-1197-1-git-send-email-stigge@antcom.de> <20120627191542.GC25319@n2100.arm.linux.org.uk> Date: Wed, 27 Jun 2012 16:26:18 -0300 Message-ID: Subject: Re: [PATCH 1/4] mtd: lpc32xx_slc: Select AMBA_PL08X in Kconfig From: Alexandre Pereira da Silva To: Russell King - ARM Linux Cc: Roland Stigge , dedekind1@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com, linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com, lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1489 Lines: 37 On Wed, Jun 27, 2012 at 4:15 PM, Russell King - ARM Linux wrote: > On Wed, Jun 27, 2012 at 05:51:12PM +0200, Roland Stigge wrote: >> From: Alexandre Pereira da Silva >> >> Since this driver depends on the amba pl08x dma driver, select it in Kconfig. >> >> Signed-off-by: Alexandre Pereira da Silva >> Signed-off-by: Roland Stigge >> --- >> ?drivers/mtd/nand/Kconfig | ? ?1 + >> ?1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig >> index de69978..a9e8b73 100644 >> --- a/drivers/mtd/nand/Kconfig >> +++ b/drivers/mtd/nand/Kconfig >> @@ -417,6 +417,7 @@ config MTD_NAND_PXA3xx >> ?config MTD_NAND_SLC_LPC32XX >> ? ? ? tristate "NXP LPC32xx SLC Controller" >> ? ? ? depends on ARCH_LPC32XX >> + ? ? select AMBA_PL08X >> ? ? ? help >> ? ? ? ? Enables support for NXP's LPC32XX SLC (i.e. for Single Level Cell >> ? ? ? ? chips) NAND controller. This is the default for the PHYTEC 3250 > > Surely not? ?Drivers using DMA engine really should not depend on any > particular DMA engine implementation. Should the DMA code in this driver be ifdef'd like in spi-pl022.c? Or just depend on DMA_ENGINE instead? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/