Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757536Ab2F0UVb (ORCPT ); Wed, 27 Jun 2012 16:21:31 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:62321 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753418Ab2F0UV3 (ORCPT ); Wed, 27 Jun 2012 16:21:29 -0400 Date: Wed, 27 Jun 2012 13:21:27 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Tejun Heo cc: Michal Hocko , Zhouping Liu , linux-mm@kvack.org, Li Zefan , CAI Qian , LKML , Andrew Morton Subject: Re: memcg: cat: memory.memsw.* : Operation not supported In-Reply-To: <20120627200926.GR15811@google.com> Message-ID: References: <2a1a74bf-fbb5-4a6e-b958-44fff8debff2@zmail13.collab.prod.int.phx2.redhat.com> <34bb8049-8007-496c-8ffb-11118c587124@zmail13.collab.prod.int.phx2.redhat.com> <20120627154827.GA4420@tiehlicka.suse.cz> <20120627200926.GR15811@google.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 28 On Wed, 27 Jun 2012, Tejun Heo wrote: > Yeah, it's kinda ugly. Taking a step back, do we really need be able > to configure out memsw? How much vmlinux bloat or runtime overhead > are we talking about? I don't think config options need to be this > granular. > Well it also has a prerequisite that memcg doesn't have: CONFIG_SWAP, so even if CONFIG_CGROUP_MEM_RES_CTLR_SWAP is folded into CONFIG_CGROUP_MEM_RES_CTLR, then these should still depend on CONFIG_SWAP since configuring them would imply there is some limit to be enforced. But to answer your question: text data bss dec hex filename 25777 3644 4128 33549 830d memcontrol.o.swap_disabled 27294 4476 4128 35898 8c3a memcontrol.o.swap_enabled Is it really too painful to not create these files when CONFIG_CGROUP_MEM_RES_CTLR_SWAP is disabled? If so, can we at least allow them to be opened but return -EINVAL if memory.memsw.limit_in_bytes is written? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/