Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755294Ab2F0UYg (ORCPT ); Wed, 27 Jun 2012 16:24:36 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:58617 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587Ab2F0UYf (ORCPT ); Wed, 27 Jun 2012 16:24:35 -0400 Date: Wed, 27 Jun 2012 13:24:30 -0700 From: Tejun Heo To: David Rientjes Cc: Michal Hocko , Zhouping Liu , linux-mm@kvack.org, Li Zefan , CAI Qian , LKML , Andrew Morton , KAMEZAWA Hiroyuki Subject: Re: memcg: cat: memory.memsw.* : Operation not supported Message-ID: <20120627202430.GS15811@google.com> References: <2a1a74bf-fbb5-4a6e-b958-44fff8debff2@zmail13.collab.prod.int.phx2.redhat.com> <34bb8049-8007-496c-8ffb-11118c587124@zmail13.collab.prod.int.phx2.redhat.com> <20120627154827.GA4420@tiehlicka.suse.cz> <20120627200926.GR15811@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 38 Hello, On Wed, Jun 27, 2012 at 01:21:27PM -0700, David Rientjes wrote: > Well it also has a prerequisite that memcg doesn't have: CONFIG_SWAP, so Right. > even if CONFIG_CGROUP_MEM_RES_CTLR_SWAP is folded into > CONFIG_CGROUP_MEM_RES_CTLR, then these should still depend on CONFIG_SWAP > since configuring them would imply there is some limit to be enforced. > > But to answer your question: > > text data bss dec hex filename > 25777 3644 4128 33549 830d memcontrol.o.swap_disabled > 27294 4476 4128 35898 8c3a memcontrol.o.swap_enabled I still wish it's folded into CONFIG_MEMCG and conditionalized just on CONFIG_SWAP tho. > Is it really too painful to not create these files when > CONFIG_CGROUP_MEM_RES_CTLR_SWAP is disabled? If so, can we at least allow > them to be opened but return -EINVAL if memory.memsw.limit_in_bytes is > written? Not at all, that was the first version anyway, which (IIRC) KAME didn't like and suggested always creating those files. KAME, what do you think? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/