Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932266Ab2F0Vwr (ORCPT ); Wed, 27 Jun 2012 17:52:47 -0400 Received: from terminus.zytor.com ([198.137.202.10]:51242 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753403Ab2F0Vwq (ORCPT ); Wed, 27 Jun 2012 17:52:46 -0400 Message-ID: <4FEB80A5.8020806@zytor.com> Date: Wed, 27 Jun 2012 14:52:37 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Olof Johansson CC: Marko Kohtala , linux-kernel@vger.kernel.org, mjg@redhat.com Subject: Re: [PATCH] efi: add efi_runtime state checking References: <1340832957-7386-1-git-send-email-olof@lixom.net> In-Reply-To: <1340832957-7386-1-git-send-email-olof@lixom.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 31 On 06/27/2012 02:35 PM, Olof Johansson wrote: > This adds an efi_runtime variable indicating whether the > efi runtime services are available. The only time they are > expected to not be available is when a 32-bit kernel has been > booted using 64-but EFI and vice versa. > > It also adds checking to the two locations where functions are > called; x86 reboot and efivars. > OK, stupid question: Why is this different from the efi_enabled variable, or rather: why is it different from what the efi_enabled variable *should* be? If runtime services aren't available the only "EFI" that is available to the kernel are the data structures passed in, and those can be checked directly... -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/