Message-ID: <1340852306.16702.74.camel@gandalf.stny.rr.com>
Subject: Re: big allocation failure during tracing init.
From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Date: Wed, 27 Jun 2012 22:58:26 -0400
In-Reply-To: <20120628022218.GA30698@redhat.com>
References: <20120622193650.GA20098@redhat.com>
	 <1340844763.16702.54.camel@gandalf.stny.rr.com>
	 <20120628022218.GA30698@redhat.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1147
Lines: 30

On Wed, 2012-06-27 at 22:22 -0400, Dave Jones wrote:
> On Wed, Jun 27, 2012 at 08:52:43PM -0400, Steven Rostedt wrote:
>  > On Fri, 2012-06-22 at 15:36 -0400, Dave Jones wrote:
>  > 
>  > > I guess the problem is on kernels built with CONFIG_MAXCPUS, struct trace_iterator
>  > > can be pretty large due to this embedded in it..
>  > > 
>  > > 	struct ring_buffer_iter *buffer_iter[NR_CPUS];
>  > > 
>  > > Any thoughts on how to change that to a smaller dynamic data structure,
>  > > without adding too much overhead to tracing ? (I'm assuming a linked-list walk
>  > > for eg would be excessive?)
>  > > 
>  > 
>  > Does this patch fix it for you?
> 
> I'm not sure what I did to trigger the allocation failure last time,
> but I'll run with this for a while, and see if anything falls out.

You probably need to do some tracing to trigger it. As it requires
opening of the trace files.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/