Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932635Ab2F1IgR (ORCPT ); Thu, 28 Jun 2012 04:36:17 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:38821 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932303Ab2F1IgM (ORCPT ); Thu, 28 Jun 2012 04:36:12 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <4FEC16EF.40408@jp.fujitsu.com> Date: Thu, 28 Jun 2012 17:33:51 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Tejun Heo CC: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel Subject: Re: [PATCH v3][0/6] memcg: prevent -ENOMEM in pre_destroy() References: <4FACDED0.3020400@jp.fujitsu.com> <20120621202043.GD4642@google.com> <4FE3ADDD.9060908@jp.fujitsu.com> <20120627175818.GM15811@google.com> In-Reply-To: <20120627175818.GM15811@google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1968 Lines: 55 (2012/06/28 2:58), Tejun Heo wrote: > Hello, KAME. > > On Fri, Jun 22, 2012 at 08:27:25AM +0900, Kamezawa Hiroyuki wrote: >> Remaining 20% of work is based on a modification to cgroup layer >> >> How do you think this patch ? (This patch is not tested yet...so >> may have troubles...) I think callers of pre_destory() is not so many... >> >> == >> From a28db946f91f3509d25779e8c5db249506cc4b07 Mon Sep 17 00:00:00 2001 >> From: KAMEZAWA Hiroyuki >> Date: Fri, 22 Jun 2012 08:38:38 +0900 >> Subject: [PATCH] cgroup: keep cgroup_mutex() while calling ->pre_destroy() >> >> In past, memcg's pre_destroy() was verrry slow because of the possibility >> of page reclaiming in it. So, cgroup_mutex() was released before calling >> pre_destroy() callbacks. Now, it's enough fast. memcg just scans the list >> and move pages to other cgroup, no memory reclaim happens. >> Then, we can keep cgroup_mutex() there. >> >> By holding looks, we can avoid following cases >> 1. new task is attached while rmdir(). >> 2. new child cgroup is created while rmdir() >> 3. new task is attached to cgroup and removed from cgroup before >> checking css's count. So, ->destroy() will be called even if >> some trashes by the task remains >> >> (3. is terrible case...even if I think it will not happen in real world..) > > Ooh, once memcg drops the __DEPRECATED_clear_css_refs, cgroup_rmdir() > will mark the cgroup dead before start calling pre_destroy() and none > of the above will happen. > Hm, threads which touches memcg should hold memcg's reference count rather than css. Right ? IIUC, one of reason is a reference from kswapd etc...hm. I'll check it. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/