Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932852Ab2F1Jes (ORCPT ); Thu, 28 Jun 2012 05:34:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60273 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932828Ab2F1Jen (ORCPT ); Thu, 28 Jun 2012 05:34:43 -0400 Date: Thu, 28 Jun 2012 12:34:43 +0300 From: "Michael S. Tsirkin" To: Cornelia Huck Cc: Alex Williamson , avi@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jan.kiszka@siemens.com Subject: Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions Message-ID: <20120628093442.GH12447@redhat.com> References: <20120627044758.23698.249.stgit@bling.home> <20120627050858.23698.44118.stgit@bling.home> <20120627162430.3477d0f6@BR9GNB5Z> <20120628083857.GD12447@redhat.com> <20120628110316.0f53a1ef@BR9GNB5Z> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120628110316.0f53a1ef@BR9GNB5Z> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1920 Lines: 58 On Thu, Jun 28, 2012 at 11:03:16AM +0200, Cornelia Huck wrote: > On Thu, 28 Jun 2012 11:38:57 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 27, 2012 at 04:24:30PM +0200, Cornelia Huck wrote: > > > On Tue, 26 Jun 2012 23:09:04 -0600 > > > Alex Williamson wrote: > > > > > > > Prune this down to just the struct kvm_irqfd so we can avoid > > > > changing function definition for every flag or field we use. > > > > > > > > Signed-off-by: Alex Williamson > > > > > > I'm currently trying to find a way to make irqfd workable for s390 > > > which will likely include using a new field in kvm_irqfd, so I'd like > > > to have this change (and I also think it makes the code nicer to read). > > > So: > > > > > > Acked-by: Cornelia Huck > > > > Unfortunately it looks like we are not sanitizing kvm_irqfd > > at all so we won't be able to use the padding :( > > We'll need a new ioctl instead. > > > > How about something like this as parameter for the new ioctl? > > struct kvm_irqfd2 { > __u32 fd; > __u32 flags; /* for things like deassign */ > __u64 type; /* determines the payload */ > union { > /* type traditional */ > struct { > __u32 gsi; > } trad; > /* type s390 */ > struct { > __u32 int_type; > __u32 parm; > __u64 parm64; > } s390; > __u8 pad[20]; > }; > } > > This could be combined with an arch or a per-kvm callback to keep the > generic code clean of architecture dependencies. > > Cornelia Looks a bit weird - shouldn't all this be part of gsi routing? But no idea really, I don't see the big picture here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/