Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755899Ab2F1RCO (ORCPT ); Thu, 28 Jun 2012 13:02:14 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:54984 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755712Ab2F1RCM convert rfc822-to-8bit (ORCPT ); Thu, 28 Jun 2012 13:02:12 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:1b02:1aa9:5ff:fe24:37a9] In-Reply-To: <4FEB80A5.8020806@zytor.com> References: <1340832957-7386-1-git-send-email-olof@lixom.net> <4FEB80A5.8020806@zytor.com> Date: Thu, 28 Jun 2012 10:02:12 -0700 Message-ID: Subject: Re: [PATCH] efi: add efi_runtime state checking From: Olof Johansson To: "H. Peter Anvin" Cc: Marko Kohtala , linux-kernel@vger.kernel.org, mjg@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1297 Lines: 33 On Wed, Jun 27, 2012 at 2:52 PM, H. Peter Anvin wrote: > On 06/27/2012 02:35 PM, Olof Johansson wrote: >> >> This adds an efi_runtime variable indicating whether the >> efi runtime services are available. The only time they are >> expected to not be available is when a 32-bit kernel has been >> booted using 64-but EFI and vice versa. >> >> It also adds checking to the two locations where functions are >> called; x86 reboot and efivars. >> > > OK, stupid question: > > Why is this different from the efi_enabled variable, or rather: why is it > different from what the efi_enabled variable *should* be? ?If runtime > services aren't available the only "EFI" that is available to the kernel are > the data structures passed in, and those can be checked directly... Excellent question, and I think it would work to turn off efi_enabled towards the end of setup_arch() for non-native boots. That'd solve all these problems, I believe. I'll try it out and revise this patch. It might take me a day or two to get cycles for it. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/