Date: Fri, 29 Jun 2012 09:21:24 +0800
From: Feng Tang <feng.tang@intel.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@elte.hu>, <linux-kernel@vger.kernel.org>,
        Robert Richter <robert.richter@amd.com>,
        Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 3/3] perf script/python: Pass event/thread/dso name
 and symbol info to event handler in python
Message-ID: <20120629092124.73428410@feng-i7>
In-Reply-To: <20120628172931.GA18586@infradead.org>
References: <1339999839-14007-1-git-send-email-feng.tang@intel.com>
	<1339999839-14007-4-git-send-email-feng.tang@intel.com>
	<20120627185817.GD20530@infradead.org>
	<20120628165027.43806b3d@feng-i7>
	<20120628172931.GA18586@infradead.org>
Organization: intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2336
Lines: 56

On Thu, 28 Jun 2012 14:29:31 -0300
Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Em Thu, Jun 28, 2012 at 04:50:27PM +0800, Feng Tang escreveu:
> > On Wed, 27 Jun 2012 15:58:17 -0300
> > Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> > > Now old scrips will break, as the tuple they expect:
> > > 
> > >  (attr, sample, raw_data)
> > > 
> > > will not be there.
> > 
> > Actually, there are no such scripts out. Current perf python script only
> > supports the trace point type, while perl scriptt has the support for
> > general events. It is my first patch "perf script: Add general python 
> > handler to process non-tracepoint events" which bring this (attr, sample,
> > raw_data) in to be on the same page as perl. So this won't be a problem
> > when the 3 patches are merged together. 
> 
> Cool, I forgot about that, thanks for correcting me :-)
> 
> But even then, perf and python diverged in this... anyway, not a big
> deal, I guess, the info available for perl scripts will be available in
> the dict as well, right?

No, current perl code will pass 4 rather raw data structures to the
script's "process_event": pevent->header, evel->attr, sample, sample->raw_data

	XPUSHs(sv_2mortal(newSVpvn((const char *)pevent, pevent->header.size)));
	XPUSHs(sv_2mortal(newSVpvn((const char *)&evsel->attr, sizeof(evsel->attr))));
	XPUSHs(sv_2mortal(newSVpvn((const char *)sample, sizeof(*sample))));
	XPUSHs(sv_2mortal(newSVpvn((const char *)sample->raw_data, sample->raw_size)));

my patch only have the last 3 ones plus extra event_name/dso_name/symobl,
while missing the "pevent->header", do you want me to add it?

>  
> > > The first two patches in this series don't apply anymore, please find
> > > them attached fixed, please check if they work as expected.
> 
> > Thanks a lot for fixing them, I'll generate perf tool patch against the
> > "perf/core" branch of your git tree on kernel.org from now on.
> > 
> > Btw, I have 2 more python scripts based on these patches, will add them
> > to this serie for your review.
> 
> Ok, will take a look at them.

Thanks,

- Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/