Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932579Ab2F2SyA (ORCPT ); Fri, 29 Jun 2012 14:54:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16072 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932341Ab2F2Sx5 (ORCPT ); Fri, 29 Jun 2012 14:53:57 -0400 Message-ID: <4FEDF963.9040700@redhat.com> Date: Fri, 29 Jun 2012 14:52:19 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Andrea Arcangeli CC: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Peter Zijlstra , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter , Alex Shi , Mauricio Faria de Oliveira , Konrad Rzeszutek Wilk , Don Morris , Benjamin Herrenschmidt Subject: Re: [PATCH 19/40] autonuma: alloc/free/init sched_autonuma References: <1340888180-15355-1-git-send-email-aarcange@redhat.com> <1340888180-15355-20-git-send-email-aarcange@redhat.com> In-Reply-To: <1340888180-15355-20-git-send-email-aarcange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 32 On 06/28/2012 08:55 AM, Andrea Arcangeli wrote: > This is where the dynamically allocated sched_autonuma structure is > being handled. > > The reason for keeping this outside of the task_struct besides not > using too much kernel stack, is to only allocate it on NUMA > hardware. So the not NUMA hardware only pays the memory of a pointer > in the kernel stack (which remains NULL at all times in that case). What is not documented is the reason for keeping it at all. What is in the data structure? What is the data structure used for? How do we use it? > + if (unlikely(alloc_task_autonuma(tsk, orig, node))) > + /* free_thread_info() undoes arch_dup_task_struct() too */ > + goto out_thread_info; Oh, you mean task_autonuma, and not sched_autonuma? Please fix the commit message and the subject. -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/