Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 21 Aug 2002 14:11:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 21 Aug 2002 14:11:55 -0400 Received: from to-velocet.redhat.com ([216.138.202.10]:56560 "EHLO touchme.toronto.redhat.com") by vger.kernel.org with ESMTP id ; Wed, 21 Aug 2002 14:11:54 -0400 Date: Wed, 21 Aug 2002 14:16:01 -0400 From: Benjamin LaHaise To: Mala Anand Cc: alan@lxorguk.ukuu.org.uk, Bill Hartner , davem@redhat.com, linux-kernel@vger.kernel.org, lse-tech@lists.sourceforge.net Subject: Re: (RFC): SKB Initialization Message-ID: <20020821141601.F8001@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from manand@us.ibm.com on Wed, Aug 21, 2002 at 01:07:09PM -0500 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 25 On Wed, Aug 21, 2002 at 01:07:09PM -0500, Mala Anand wrote: > > >On Wed, Aug 21, 2002 at 11:59:44AM -0500, Mala Anand wrote: > >> The patch reduces the numer of cylces by 25% > > >The data you are reporting is flawed: where are the average cycle > >times spent in __kfree_skb with the patch? > > I measured the cycles for only the initialization code in alloc_skb > and __kfree_skb. Since the init code is removed from __kfree_skb, > no cycles are spent there. Then the testing technique is flawed. You should include all of the operations included in an alloc_skb/kfree_skb pair in order to see the overall effect of the change, otherwise your change could have a net negative effect which would not be noticed. -ben -- "You will be reincarnated as a toad; and you will be much happier." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/