Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753328Ab2HAMWy (ORCPT ); Wed, 1 Aug 2012 08:22:54 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:35321 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958Ab2HAMWx (ORCPT ); Wed, 1 Aug 2012 08:22:53 -0400 Date: Wed, 1 Aug 2012 14:24:43 +0200 From: Fabio Baltieri To: Marc Kleine-Budde Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Hartkopp , Wolfgang Grandegger Subject: Re: [PATCH can-next v5 2/2] can: flexcan: add LED trigger support Message-ID: <20120801122443.GA1311@gmail.com> References: <5018F8B3.6080404@pengutronix.de> <1343821782-1346-1-git-send-email-fabio.baltieri@gmail.com> <1343821782-1346-2-git-send-email-fabio.baltieri@gmail.com> <501918B2.6070703@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <501918B2.6070703@pengutronix.de> X-Operating-System: Linux balto-eee 3.5.0-balto-eee-08206-g141684a GNU/Linux User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 22 On Wed, Aug 01, 2012 at 01:53:22PM +0200, Marc Kleine-Budde wrote: [...] > > @@ -635,6 +638,7 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) > > if (reg_iflag1 & (1 << FLEXCAN_TX_BUF_ID)) { > > stats->tx_bytes += can_get_echo_skb(dev, 0); > > stats->tx_packets++; > > + can_led_event(dev, CAN_LED_EVENT_TX); > > Should the led blink on TX or TX completion interrupt? I'd say on complention interrupt, together with can_get_echo_skb(). That was briefly discussed with Oliver in my first patch: http://article.gmane.org/gmane.linux.can/1007 Fabio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/