Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715Ab2HAOVD (ORCPT ); Wed, 1 Aug 2012 10:21:03 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:65152 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754227Ab2HAOUi (ORCPT ); Wed, 1 Aug 2012 10:20:38 -0400 MIME-Version: 1.0 In-Reply-To: <20120729215301.GA27358@srcf.ucam.org> References: <1343407934-459-1-git-send-email-mjg@redhat.com> <1343407934-459-3-git-send-email-mjg@redhat.com> <1343598582.15288.4.camel@shinybook.infradead.org> <20120729215301.GA27358@srcf.ucam.org> From: Bjorn Helgaas Date: Wed, 1 Aug 2012 08:20:15 -0600 Message-ID: Subject: Re: [PATCH] Fix priority of non-BAR ROM data To: Matthew Garrett Cc: David Woodhouse , matt.fleming@intel.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 17 On Sun, Jul 29, 2012 at 3:53 PM, Matthew Garrett wrote: > On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote: >> + * Some devices may provide ROMs via a source other than the BAR >> + */ >> + if (pdev->rom && pdev->romlen) { >> + *size = pdev->romlen; >> + return phys_to_virt(pdev->rom); > > Needs casting. My mistake. Matthew, are you going to fold this into your patch and repost your series, or is this a logically separate issue? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/