Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755316Ab2HAVFe (ORCPT ); Wed, 1 Aug 2012 17:05:34 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.162]:21199 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825Ab2HAVFc (ORCPT ); Wed, 1 Aug 2012 17:05:32 -0400 X-RZG-AUTH: :P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrcy6sj4gft1kacwec3HuWvN1TWpKmxUw== X-RZG-CLASS-ID: mo00 Date: Wed, 1 Aug 2012 23:05:28 +0200 (CEST) From: Oliver Hartkopp Reply-To: Oliver Hartkopp To: linux-can@vger.kernel.org, Fabio Baltieri Cc: linux-kernel@vger.kernel.org, Wolfgang Grandegger , Marc Kleine-Budde Message-ID: <1175619568.117607.1343855128267.JavaMail.open-xchange@webmail.strato.de> In-Reply-To: <1343845298-2065-1-git-send-email-fabio.baltieri@gmail.com> References: <50191EA5.1040303@pengutronix.de> <1343845298-2065-1-git-send-email-fabio.baltieri@gmail.com> Subject: Re: [PATCH can-next v6] can: add tx/rx LED trigger support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v6.20.6-Rev3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 24 Fabio Baltieri hat am 1. August 2012 um 20:21 geschrieben: > so, v6, change trigger names for fixed size allocation capped to (IFNAMSIZ + > 4) > and removed kasprintf as suggested by Oliver (thanks!). > > This also has the side effect of reducing the error path to just one check to > devres_alloc return value... nice! > > I've put CAN_LED_NAME_SZ definition with the active function declaration, > but used sizeof(priv->tx_led_trig_name) as snprintf length argument in the > code, as it looks cleaner to me. Yes. Nice improvement. Thanks Fabio! Acked-by: Oliver Hartkopp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/