Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751214Ab2HBESa (ORCPT ); Thu, 2 Aug 2012 00:18:30 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:51704 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786Ab2HBES3 (ORCPT ); Thu, 2 Aug 2012 00:18:29 -0400 MIME-Version: 1.0 In-Reply-To: <1343878276-4108-1-git-send-email-fdu@windriver.com> References: <1343878276-4108-1-git-send-email-fdu@windriver.com> Date: Wed, 1 Aug 2012 21:18:28 -0700 Message-ID: Subject: Re: [PATCH] MIPS: oops when show backtrace of all active cpu From: Kevin Cernekee To: Fan Du Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, vincent wen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 26 On Wed, Aug 1, 2012 at 8:31 PM, Fan Du wrote: > show_backtrace must have an valid task when calling unwind_stack, > so fix it by checking first. [...] > --- a/arch/mips/kernel/traps.c > +++ b/arch/mips/kernel/traps.c > @@ -151,6 +151,10 @@ static void show_backtrace(struct task_struct *task, const struct pt_regs *regs) > show_raw_backtrace(sp); > return; > } > + > + if (task == NULL) > + task = current; > + > printk("Call Trace:\n"); > do { > print_ip_sym(pc); FYI, a slightly different version of this change was accepted: https://patchwork.linux-mips.org/patch/3524/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/