Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753776Ab2HBNRL (ORCPT ); Thu, 2 Aug 2012 09:17:11 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:63639 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540Ab2HBNRJ (ORCPT ); Thu, 2 Aug 2012 09:17:09 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6790"; a="217520374" Message-ID: <340c1ff468880f247cc9377705edd6e4.squirrel@www.codeaurora.org> In-Reply-To: <5017FDCE.5030700@kernel.dk> References: <1343744710-31700-2-git-send-email-merez@codeaurora.org> <09c3a301ad7ca4fa396c4d00615312c1.squirrel@www.codeaurora.org> <5017FDCE.5030700@kernel.dk> Date: Thu, 2 Aug 2012 06:16:48 -0700 (PDT) Subject: Re: [PATCH v5 1/3] block: Add test-iosched scheduler From: merez@codeaurora.org To: "Jens Axboe" Cc: merez@codeaurora.org, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, "DOCUMENTATION" , "open list" User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2197 Lines: 57 On Tue, July 31, 2012 8:46 am, Jens Axboe wrote: > On 07/31/2012 04:36 PM, merez@codeaurora.org wrote: >> Hi Jens, >> >> Do you have comments on this patch? >> Can we push it to kernel 3.6 version? > > I have questions - what is this good for? In other words, explain to me > why this is useful code. And in particular why this cannot be done from > userspace with bsg and block tracing? > > IOW, I'm dubious as to whether a new _io scheduler_ is the correct > solution to the problem you have at hand. > > -- > Jens Axboe > > The test scheduler allows us to control the dispatched requests and their order without an interfering of other requests. You can review the patches which depends on this patch in order to better understand how it is used. For example, in the eMMC4.5 packed commands feature, the MMC layer can pack read or write requests (the packed requests must be of the same direction). MMC layer will stop fetching the requests in case the packing conditions are broken. In order to test this feature we had to have a full control on the requests that the MMC layer fetches and their order, so that we will be able to determine if the expected behavior was actually achieved. The test-iosched can call specific block device callbacks, for example for checking the test results. Also, in order to be able to run out tests on the main eMMC card that runs in HS200, we cannot "shut down" the real FS requests, otherwise our phone won't come up or crash. The test-iosched allows us to delay the real FS requests until the end of the test, therefore the tests can be done on the main eMMC card. We chose not to use blocktrace due to the "real" FS requests interference in the middle of the test. I'm not familiar with bsg so I cannot tell if it can answer all the requirements I specified above. Thanks, Maya -- Sent by consultant of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/