Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730Ab2HBOS4 (ORCPT ); Thu, 2 Aug 2012 10:18:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40737 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484Ab2HBOSz (ORCPT ); Thu, 2 Aug 2012 10:18:55 -0400 Date: Thu, 2 Aug 2012 10:18:47 -0400 From: Benjamin Poirier To: Borislav Petkov , Borislav Petkov , Michal Marek , Lucas De Marchi , Arnaud Lacombe , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH 0/6] menuconfig: jump to search results Message-ID: <20120802141847.GB21766@d2.synalogic.ca> References: <1343676130-29770-1-git-send-email-bpoirier@suse.de> <20120730195826.GA8242@liondog.tnic> <20120730202212.GA31790@d2.synalogic.ca> <20120731075751.GB23595@liondog.tnic> <20120731131751.GA10910@d2.synalogic.ca> <20120802133252.GA3752@x1.osrc.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120802133252.GA3752@x1.osrc.amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 34 On 2012/08/02 15:32, Borislav Petkov wrote: > On Tue, Jul 31, 2012 at 09:17:51AM -0400, Benjamin Poirier wrote: > > > * when searching for "DELAY" for example, I get results without numbers > > > to which I can't jump to: > > > > > > ... > > > │ Symbol: DEFAULT_IO_DELAY_TYPE [=0] > > > │ Type : integer > > > │ > > > │ > > > │ Symbol: IO_DELAY_TYPE_0X80 [=0] > > > │ Type : integer > > > ... > > > > > > maybe because they don't have "---help---" section? > > > > Because they don't have a prompt - they don't appear in any menu at all. > > In that case there's nowhere to jump to. That's why those symbols don't > > get a number. > > Right, so how about you don't show them at all then? It's a search for CONFIG_ symbols not "menus". Even though the user doesn't have direct control over some symbols, it's still useful to know they exist and (possibly) what enables them. For example, searching for LOCKDEP tells me I can enable DEBUG_LOCK_ALLOC to get it. Besides, this patchset to add the jumps keys didn't change that behavior at all. You're gonna get the same search results with the current menuconfig. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/