Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 22 Aug 2002 01:44:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 22 Aug 2002 01:44:01 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:635 "EHLO frodo.biederman.org") by vger.kernel.org with ESMTP id ; Thu, 22 Aug 2002 01:44:00 -0400 To: Jeff Garzik Cc: Andre Hedrick , "Heater, Daniel (IndSys, GEFanuc, VMIC)" , "'Padraig Brady'" , "'Linux Kernel'" Subject: Re: IDE-flash device and hard disk on same controller References: <3D62BC10.3060201@mandrakesoft.com> <3D62C2A3.4070701@mandrakesoft.com> From: ebiederm@xmission.com (Eric W. Biederman) Date: 21 Aug 2002 23:34:21 -0600 In-Reply-To: <3D62C2A3.4070701@mandrakesoft.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 18 Jeff Garzik writes: > Jeff Garzik wrote: > > Attached is the ATA core... > > Just to give a little bit more information about the previously attached code, > it is merely a module that does two things: (a) demonstrates proper [and > sometimes faster-than-current-linus] ATA bus probing, and I am assuming ata_chan_init is the function that does this demonstration. I don't see any checking for the ATA bsy flag before you start sending commands. I have seen the current IDE code fail too many times if I boot to fast, because of a lack of this one simple test. So I don't see how this could be considered a proper probe. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/