Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628Ab2HBOtU (ORCPT ); Thu, 2 Aug 2012 10:49:20 -0400 Received: from na3sys009aog134.obsmtp.com ([74.125.149.83]:59329 "EHLO na3sys009aog134.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822Ab2HBOtT (ORCPT ); Thu, 2 Aug 2012 10:49:19 -0400 MIME-Version: 1.0 In-Reply-To: <1343891231-3042-1-git-send-email-kyungsik.lee@lge.com> References: <1343891231-3042-1-git-send-email-kyungsik.lee@lge.com> From: "S, Venkatraman" Date: Thu, 2 Aug 2012 20:18:54 +0530 Message-ID: Subject: Re: [PATCH RESEND v5] mmc: core: Remove bounce buffer in mmc_send_cxd_data() To: Kyungsik Lee Cc: Chris Ball , Jaehoon Chung , raphael.andy.lee@gmail.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 27 On Thu, Aug 2, 2012 at 12:37 PM, Kyungsik Lee wrote: > It is expected that Extended CSD register(the size of this register > is larger than CID/CSD) will be referenced more frequently as more > fields have been added to Extended CSD and it seems that it is not > a good option to double the memory used. > > This patch is intended to avoid the use of bounce buffer for reading > Extended CSD register in mmc_send_cxd_data(). It will provide a better > performance gain by removing memcpy() overhead for a half KiB and > a redundant bounce buffer allocated repeatedly at the cost of providing > DMA-capable buffer from upper caller(but on-stack buffer is allowed > with no performance gain). > > Signed-off-by: Kyungsik Lee > Signed-off-by: S, Venkatraman I don't think my sign off is warranted. I gave just an illustration. You can add my Reviewed-by: Venkatraman S Regards, Venkat. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/